sinatra / mustermann

your personal string matching expert
http://sinatrarb.com/mustermann/
MIT License
664 stars 63 forks source link

Move the following gems to a single meta gem, called mustermann-contrib: #53

Closed zzak closed 8 years ago

zzak commented 8 years ago

We will no longer support mustermann-everything instead, this gem replaces it.

namusyaka commented 8 years ago

Why do you want to move gems to the single meta gem? I don't think this is reasonable because this change makes require the all unnecessary code even if developer would like to use mustermann-simple. I think all mustermann patterns should be separated as a gem.

zzak commented 8 years ago

@namusyaka After talking with @rkh about this, he suggested to combine the extra plugins to make release maintenance easier.

This change wouldn't be included until Mustermann 1.0.0, which I will cut once this is done.

The argument is most of these plugins are really small, and aren't autoloaded so the only would be disk space and network bandwidth when installing the gem. However, it's fair to assume most applications have tens if not hundreds of dependencies already, and this would actually cut down the number of packages required to download and install. As well, the real win here, is that I only have to cut 2 gems to release all of Mustermann and going forward is a much more sustainable strategy.

zzak commented 8 years ago

Also, I think this is OK to merge if everyone is happy and then I can cut a pre-release of Mustermann 1.0!

namusyaka commented 8 years ago

@zzak Hmm, makes sense. Thanks for the thorough explanation. I don't intend to deny the approach already if having obtained a consensus.

zzak commented 8 years ago

@namusyaka If there's any gem included here you'd like to take over (such as mustermann-grape), I'm happy to leave it out and you're free to maintain it separately.