search

sinatra / mustermann

your personal string matching expert
http://sinatrarb.com/mustermann/
MIT License
664 stars 63 forks source link

Jruby Support #72

Open dometto opened 7 years ago

dometto commented 7 years ago

The docs state that jruby is currently not supported, but I can gem install mustermann just fine. Is it ready for use with jruby after all?

I have tried to run the specs on jruby, but this fails because the redcarpet gem required by support is not compatible (it relies on posix-spawn). If I disable the redcarpet dependency in the gemspec, the specs run but result in 23 failures. I take it that is not related to removingredcarpet (since else I should be seeing errors concerning that)?

If not that, can you indicate what needs to happen to fully support jruby? I would be interested in getting that running so when can upgrade gollum to sinatra v2.

zzak commented 7 years ago

Hi @dometto,

I'm not sure why it's not supported to be honest, but your experience leads me to believe that it isn't.

As far as adding support, I'd need a patch to get it building under CI.

Is this something you'd be interested in working on?

epergo commented 3 years ago

I have tried to run the specs on jruby, but this fails because the redcarpet gem required by support is not compatible (it relies on posix-spawn). If I disable the redcarpet dependency in the gemspec, the specs run but result in 23 failures. I take it that is not related to removingredcarpet (since else I should be seeing errors concerning that)?

Is it redcarpet even used at all? I fail to find where is being used

Update: Removed at https://github.com/sinatra/mustermann/pull/115

dentarg commented 2 years ago

Looks like there's a bunch of things to investigate for JRuby support: https://github.com/sinatra/mustermann/runs/7393804603?check_suite_focus=true#step:4:1