search

sinatra / mustermann

your personal string matching expert
http://sinatrarb.com/mustermann/
MIT License
664 stars 63 forks source link

Hash expansion needs removed from `**options` in call to `#pattern_from`. #95

Closed brett-novu closed 2 years ago

brett-novu commented 5 years ago

https://github.com/sinatra/mustermann/blob/34093954a77bbef159fa2a9fb3afc1c4b8354cda/mustermann/lib/mustermann/composite.rb#L14

This line should be:

Mustermann[type || Mustermann::DEFAULT_TYPE].supported?(option, options)
jkowens commented 2 years ago

I'm not sure this really needs changed. If you can provide a failing spec to demonstrate that would be helpful.

jkowens commented 2 years ago

Ah this was probably fixed with this PR #97.