search

sinatra / sinatra-recipes

Community contributed recipes and techniques
http://recipes.sinatrarb.com/
463 stars 142 forks source link

Fix selected item in select #120

Closed piton4eg closed 9 years ago

kgrz commented 9 years ago

Hmm, it seems Chosen (the plugin for handling the dropdown) handles setting the selected attribute for us. Can you please explain what this PR does and when it's applicable?

piton4eg commented 9 years ago

When you select one of item then Chosen reload page and this reload resets selected item in select element. This PR fix it

piton4eg commented 9 years ago

@kgrz rebased

kgrz commented 9 years ago

On which browser are you seeing this issue? I checked on Safari—master branch—and it works fine.

piton4eg commented 9 years ago

I checked on Chrome, Safari, it looks the same. I recorded video for showing what's wrong: 1st - http://recipes.sinatrarb.com/, 2nd - my local branch with fix: http://screencast.com/t/kHk2u9RU

kgrz commented 9 years ago

Thanks for the patience to explain this. Merging this.