Closed ashleygwilliams closed 8 years ago
Sinatra::Reloader docs should go in contrib, see #56
sure, but imagine the use case where a windows user goes to sinatra recipes and wants a reloader. we don't have to include the article, but there should be a single reloader page then that lists shotgun, rerun, and at least references the contrib project; not doing that makes discovery of reloader super hard. thoughts?
@ashleygwilliams We actually had a few issues with reloader on windows, some of them might be resolved with the latest contrib release (after removing eventmachine as a dependency).
I'm not against a short reference mentioning the gem, by all means.
@ashleygwilliams ping agdubz
Ashley mentioned that I can merge these PRs if they are okay. Will merge this since this looks like a good starting point for reloaders.
@kgrz In retrospect, I don't think this is enough to warrant a recipe.
If any of this information is missing from the sinatra-contrib documentation, that would be the appropriate place. IMO.
hmm, okay. Do you want me to revert this then?
@kgrz Yeah, as long as we plan to support reloader, we should do our best to give the first-class docs our love <3
@zzak asked for a Rack::Reloader recipe in #44
this isn't that, but: 1) it's worthwhile to have this alongside the shotgun recipe, since that doesn't work for Windows. 2) what's the motivation behind a rack::reloader recipe, exactly?
this is a bit of a rewrite of http://www.sinatrarb.com/contrib/reloader.html which i think is a lil confusing (don't weave classic + modular app implementations, just present each individually, IMO)
i'm also going to write up a recipe for rerun. do we think that reloader, shotgun, and rerun should all be one article on reloaders? 3 makes a category, right, heh?