Closed nacengineer closed 7 years ago
ok this is great. thanks so much @nacengineer !!
last thought: is there any reason to even keep kill -9
in there? feel like we should be opinionated in the docs and just take it out entirely since it's really inadvisable compared to -WINCH
.
i'd say take it out and then i'll merge, unless anyone else has any comments.
Well kill -9 it is less advisable, but perfectly fine as a last recourse. It is needed for the times when the process won't respond to the kill -QUIT flag which does happen sometime.
wrd fair fair. i'd say title it "Slaying Unicorn" with a sub section called "last resort" at the end of the section. seem like a good compromise?
have at it! :P
On Thu, Sep 26, 2013 at 1:26 PM, Ashley Williams notifications@github.comwrote:
wrd fair fair. i'd say title it "Slaying Unicorn" with a sub section called "last resort" at the end of the section. seem like a good compromise?
— Reply to this email directly or view it on GitHubhttps://github.com/sinatra/sinatra-recipes/pull/73#issuecomment-25191296 .
@ashleygwilliams How do you feel about this one?
Quite late, but I suppose all the comments have been fixed? Can this be merged?
/ cc @ashleygwilliams
although you can use kill -9 to stop unicorn. its better to use WINCH/QUIT.