search

sinatra / sinatra

Classy web-development dressed in a DSL (official / canonical repo)
https://sinatrarb.com
MIT License
12.17k stars 2.06k forks source link

Update streaming to make use of Rack "callable body" #1892

Open dentarg opened 1 year ago

dentarg commented 1 year ago

Instead of adding support for either full or partial hijack, Sinatra should make use of "callable body" (https://github.com/rack/rack/pull/1745) introduced with Rack 3: https://github.com/rack/rack/blob/9eb4aa2646fdaaf22c7f6a9fa4c6dc73e587204f/UPGRADE-GUIDE.md#response-bodies-can-be-used-for-bi-directional-streaming

Originally posted by @dentarg in https://github.com/sinatra/sinatra/issues/604#issuecomment-1426416959

dentarg commented 2 months ago

I think this is relevant to look at/read: https://github.com/rails/rails/pull/52094