search

sinbad / SPUD

Steve's Persistent Unreal Data library
MIT License
308 stars 45 forks source link

SPUD on 4.26 #1

Closed poettlr closed 3 years ago

poettlr commented 3 years ago

Hello Steve,

I'm currently trying SPUD out on UE4.26 since it seems to be exactly what I need at the moment. I wanted to notify you, that the compilation on 4.26 does not work out of the box and since I have not been able to test everything as of yet. I just wanted to let you know of the changes I had to do on my side.

4.26 changed FArchiveProxy to include FArchiveProxy(FArchiveProxy&&) = delete; FArchiveProxy(const FArchiveProxy&) = delete; FArchiveProxy& operator=(FArchiveProxy&&) = delete; FArchiveProxy& operator=(const FArchiveProxy&) = delete;

Which now results in a compile error: SpudState.cpp: [C2280] 'FSpudChunkedDataArchive::FSpudChunkedDataArchive(const FSpudChunkedDataArchive &)': attempting to reference a deleted function

I changed the lines auto ChunkedAR = FSpudChunkedDataArchive(Ar); to FSpudChunkedDataArchive ChunkedAr(Ar);

Also I had to include in SpudPropertyUtil.cpp on my end.

Would have def. made a pull request, but as I said, I was not able to test everything as of now. Sorry for the inconvenience :)

Cheers

sinbad commented 3 years ago

Thanks, I haven't updated to 4.26 yet so that's helpful. I'll try to get something in that at least compiles, hopefully I'll get to test it more soon.

sinbad commented 3 years ago

Also I had to include in SpudPropertyUtil.cpp on my end.

What did you mean by this BTW? Do you mean you had to include it in your project? It should just get included in the SPUD project generation just by being there in the folder.

I think maybe I need to add SPUD_API to the front of that util class because of some inlining, not sure why it's not complaining in 4.25 for me.

sinbad commented 3 years ago

I've tested with 4.26.1 now and everything seems fine after the fixes. :)