search

sinbad / SPUD

Steve's Persistent Unreal Data library
MIT License
336 stars 51 forks source link

Update to 5.4 #75

Closed Rcurreli closed 5 months ago

Rcurreli commented 5 months ago

Hello,

I tried to compile SPUD with the new 5.4 version and I found just few little errors:

Unreal made some change to this class: UE_5.4\Engine\Source\Runtime\Core\Public\String\FormatStringSan.h so this assert:

FMT_STR_ERR(StatusSNeedsTCHARPtrArg, "'%s' expects `TCHAR*`; use '%hs' for `const char*`.");
FMT_STR_ERR(StatusIncompleteFormatSpecifierOrUnescapedPercent, "incomplete '%' escape sequence. (to print a percent sign, write '%%'.)");

stop spud to compile in few lines of this file: Plugins\SPUD\Source\SPUD\Private\SpudState.cpp

I intuitively corrected the 3 lines and 5.4 compiles successfully and saving seems to work:

image

Can you please commit the fix and make SPUD compatible with the 5.4 version?

sinbad commented 5 months ago

Thanks, these were warnings that I missed, they became errors in 5.4. The first one should actually be "%s" not "%%" so I've fixed that.