search

sinclairzx81 / typebox

Json Schema Type Builder with Static Type Resolution for TypeScript
Other
4.98k stars 157 forks source link

JsonTypeBuilder#Record not passing on options #739

Closed gregerolsson closed 9 months ago

gregerolsson commented 9 months ago

Options object passed to JsonTypeBuilder#Record is not passed on to free Record function

This prevents [Kind]: "Record" types from having $id, title, and so on.

I can make a PR if you prefer, but since its just a 1-liner fix perhaps it can be sorted while you're doing other changes.

Oh, and thanks for a fantastic library ❤️

sinclairzx81 commented 9 months ago

@gregerolsson Hi,

Thanks for reporting! Have published a fix on 0.32.12 and written option assignment tests to try and catch missed option passing in future (during refactors, forgetting to pass in the options when refactoring has been a common oversight, they're easy to forget!)

All the best! S