search

sinclairzx81 / typebox

Json Schema Type Builder with Static Type Resolution for TypeScript
Other
4.56k stars 148 forks source link

Pin TypeScript to minor version since it is not semantically versioned #922

Closed kevinlul closed 1 week ago

kevinlul commented 1 week ago

See microsoft/TypeScript#14116

sinclairzx81 commented 1 week ago

@kevinlul Hi, thanks for this PR

At this stage, I'm happy with the current setup as TypeBox pulls across (and tests) a variety of compiler versions and generally updates to the latest published version of the compiler via @latest. Making a distinction between semver or otherwise doesn't really implicate the project as it's generally built and updated to work with the latest published compiler while testing several exact prior versions (with much of the testing done via project tasks)

Thanks tho, PR's are appreciated, but will close this one out and things are fairly good here. Cheers S

kevinlul commented 1 week ago

I should have checked https://github.com/sinclairzx81/typebox/blob/master/.github/workflows/nightly.yml, I missed that you're testing against typescript@latest and typescript@next so the actual version in devDependencies is immaterial.