Closed NoahKamara closed 11 months ago
I figured out a way to implement this without using the contact hack. A choose from list action will by default show the DisplayRepresentation title subtitle and image so I just implemented it using that
A user can currently choose between Emoji and SF Symbol for the icon as well as apply a background and foreground (only symbol) color
@sindresorhus is there a requirement for using a single app per Action?
Thanks for working on this 👍
@sindresorhus is there a requirement for using a single app per Action?
By "app", do you mean "file". If so, yes, I would prefer to keep an action and related types in one file. Otherwise it simply ends up being too many files.
Code should be tab-indented.
You have many lint warnings. See the diff.
readme should also updated at section Included actions
I won't be able to try this out until Xcode 15 RC is out, probably in a week.
You need to resolve the merge conflict.
Thanks :)
Btw, this still required substantial clean up: https://github.com/sindresorhus/Actions/commit/5455817eb72ee5d5a1f065c578776f55b7c4f10f In case you are interested in seeing what to improve upon. It was easier to do it afterwards than to comment on everything. I also found a bunch of minor bugs. Some things here are just based on my preference though.
Fixes #141
To Do