sindresorhus / Actions

⚙️ Supercharge your shortcuts
https://sindresorhus.com/actions
MIT License
2.58k stars 109 forks source link

Add `Create Menu Item` Action #144

Closed NoahKamara closed 11 months ago

NoahKamara commented 1 year ago

Fixes #141

To Do

NoahKamara commented 1 year ago

I figured out a way to implement this without using the contact hack. A choose from list action will by default show the DisplayRepresentation title subtitle and image so I just implemented it using that

A user can currently choose between Emoji and SF Symbol for the icon as well as apply a background and foreground (only symbol) color

@sindresorhus is there a requirement for using a single app per Action?

sindresorhus commented 1 year ago

Thanks for working on this 👍

sindresorhus commented 1 year ago

@sindresorhus is there a requirement for using a single app per Action?

By "app", do you mean "file". If so, yes, I would prefer to keep an action and related types in one file. Otherwise it simply ends up being too many files.

sindresorhus commented 1 year ago

Code should be tab-indented.

sindresorhus commented 1 year ago

You have many lint warnings. See the diff.

muescha commented 1 year ago

readme should also updated at section Included actions

sindresorhus commented 1 year ago

I won't be able to try this out until Xcode 15 RC is out, probably in a week.

sindresorhus commented 12 months ago

You need to resolve the merge conflict.

sindresorhus commented 11 months ago

Thanks :)

sindresorhus commented 11 months ago

Btw, this still required substantial clean up: https://github.com/sindresorhus/Actions/commit/5455817eb72ee5d5a1f065c578776f55b7c4f10f In case you are interested in seeing what to improve upon. It was easier to do it afterwards than to comment on everything. I also found a bunch of minor bugs. Some things here are just based on my preference though.