search

sindresorhus / Actions

⚙️ Supercharge your shortcuts
https://sindresorhus.com/actions
MIT License
2.49k stars 103 forks source link

Get Dominant Colors of Image doesn’t get accurate colours. #214

Closed raikesy closed 5 months ago

raikesy commented 6 months ago

Description

Unrelated to the list order bug affecting this action, the colours returned by this action appear to be more faded/pastel versions of the actual colours in the image. I have created a shortcut that demonstrates this when using a Home Screen screenshot as input.

Not sure if related but the action doesn’t always pick up every colour, for example it doesn’t return the white colour in several of the icons in the attached output. Image

macOS/iOS version

17.2.1

Shortcut URL

https://www.icloud.com/shortcuts/699a34a04f3e4f869ec91813c0f18d10

sindresorhus commented 6 months ago

Can you try out the latest TestFlight build (62) and let me know whether it improves it? It's using a new algorithm for getting the dominant color.

https://testflight.apple.com/join/fJGUrsZx

raikesy commented 6 months ago

Seems to be a significant improvement: Image

But still a couple of odd results (Trainline, lebara).

sindresorhus commented 6 months ago

Are you sure the problem is not your shortcut?

I tried getting the dominant color for the Trainline icon alone and it works fine for me.

Screenshot 2024-01-11 at 02 35 00 Screenshot 2024-01-11 at 02 32 05