search

sindresorhus / Gifski

🌈 Convert videos to high-quality GIFs on your Mac
https://sindresorhus.com/gifski
MIT License
7.79k stars 295 forks source link

Split the `Gifski.run()` method into multiple smaller methods #238

Closed ejensen closed 3 years ago

ejensen commented 3 years ago

When adding support for reversing gifs (PR #239), I noticed this TODO

// TODO: Split this method up into smaller methods. It's too large.

I split up this 260 line run method into 4 methods

sindresorhus commented 3 years ago

This looks great. Thanks for the cleanup! 🙌

If you notice anything else that could be improved, feel free to open an issue or PR about it ;)