sindresorhus / Gifski

🌈 Convert videos to high-quality GIFs on your Mac
https://sindresorhus.com/gifski
MIT License
7.83k stars 294 forks source link

SwiftUI crash in validateDimension #1 (min:ideal:max:) #259

Closed ptrkstr closed 3 years ago

ptrkstr commented 3 years ago

Meta:

Steps:

  1. Download following mp4: https://giphy.com/gifs/the-office-mrw-d10dMmzqCYqQ0
  2. Open Gifski
  3. Drag and drop or open file window to the above file

Expected:

Actual:

Crash Details:

Thread 0 Crashed::  Dispatch queue: com.apple.main-thread
0   SwiftUI                             0x7ff90b3cf81f validateDimension #1 (min:ideal:max:) in NSView.intrinsicLayoutTraits() + 230
1   SwiftUI                             0x7ff90b3cec92 NSView.intrinsicLayoutTraits() + 99
2   SwiftUI                             0x7ff90b3ceb7d PlatformViewHost.updateLayoutTraits() + 266
3   SwiftUI                             0x7ff90b4b15bd closure #1 in ViewLeafView.layoutTraits() + 146
4   SwiftUI                             0x7ff90b4b1518 ViewLeafView.layoutTraits() + 43
5   SwiftUI                             0x7ff90b4b13cc closure #1 in ViewLeafView.sizeThatFits(in:) + 143
6   SwiftUI                             0x7ff90b4b1258 ViewLeafView.sizeThatFits(in:) + 185
7   SwiftUI                             0x7ff90adc6bdc closure #1 in LeafLayoutEngine.sizeThatFits(_:) + 51
...
sindresorhus commented 3 years ago

Thanks for reporting. This is a macOS 12 bug and was worked around in Gifski 2.19.3.

ptrkstr commented 3 years ago

Thank you for fixing it @sindresorhus ❤️