search

sindresorhus / Gifski

🌈 Convert videos to high-quality GIFs on your Mac
https://sindresorhus.com/gifski
MIT License
7.72k stars 290 forks source link

Update gif.ski to 1.6.1 #263

Closed kornelski closed 2 years ago

kornelski commented 2 years ago

GCC no longer required. Now multi-threading is built-in. Also uses new fancy almost-native Xcode project file instead of a Makefile.

Fixes #85 Fixes #261

sindresorhus commented 2 years ago

It seems like this fixes #261. Did you do anything to specifically fix it? 148274565-5ec81390-60fc-4eab-ad18-b2839deca842

sindresorhus commented 2 years ago

Performance seems to be the same or slightly better 👍

sindresorhus commented 2 years ago

Can you update https://github.com/sindresorhus/Gifski/blob/f8f3c8a3f39845c01349383c3abadb934cd58939/readme.md?plain=1#L76 with how to build the gif.ski static library now?

sindresorhus commented 2 years ago

I'm getting a warning when building:

ld: warning: object file (/Users/sindresorhus/Library/Developer/Xcode/DerivedData/Gifski-covufrfbnkqrunfagfxjgrfngrhp/Build/Products/Release/libgifski_static.a(quantize.o)) was built for newer macOS version (12.1) than being linked (10.15)

I think you need to set the macOS target in the gifski-api project to macOS 10.15 (same as Gifski).

kornelski commented 2 years ago

New gifski uses the latest imagequant, which has improved selection of colors for low-color images.

sindresorhus commented 2 years ago

@kornelski When archiving Gifski, I now get an error from the new build stuff:

Multiple commands produce '/Users/sindresorhus/Library/Developer/Xcode/DerivedData/Gifski-covufrfbnkqrunfagfxjgrfngrhp/Build/Intermediates.noindex/ArchiveIntermediates/Gifski/BuildProductsPath/Release/libgifski_static.a': 1) That command depends on command in Target 'gifski-staticlib' (project 'gifski'): script phase “Universal Binary lipo” 2) Target 'gifski-staticlib' (project 'gifski') has symlink command from '/Users/sindresorhus/Library/Developer/Xcode/DerivedData/Gifski-covufrfbnkqrunfagfxjgrfngrhp/Build/Intermediates.noindex/ArchiveIntermediates/Gifski/BuildProductsPath/Release/libgifski_static.a' to '/Users/sindresorhus/Library/Developer/Xcode/DerivedData/Gifski-covufrfbnkqrunfagfxjgrfngrhp/Build/Intermediates.noindex/ArchiveIntermediates/Gifski/IntermediateBuildFilesPath/UninstalledProducts/macosx/libgifski_static.a'

kornelski commented 2 years ago

Eh, Xcode…

I think I've fixed it. https://github.com/sindresorhus/Gifski/pull/264 It turns out that BUILT_PRODUCTS_DIR is not the dir where you put products you've built.