search

sindresorhus / Gifski

🌈 Convert videos to high-quality GIFs on your Mac
https://sindresorhus.com/gifski
MIT License
7.72k stars 290 forks source link

Add m1-friendly swiftlint script to build phase. #283

Closed ben-p-commits closed 1 year ago

ben-p-commits commented 1 year ago

Add m1-friendly swiftlint script to build phase. Homebrew on mac silicon has a different installation path (opt/homebreow), so this catches both m1 and x86 scenarios.

This script came from an issue on the swiftlint repository.

image

Fixes #284

sindresorhus commented 1 year ago

I think you can just add to the path without testing it first. It makes no difference. And we don't really need the handholding.

This should be enough

PATH="/opt/homebrew/bin/:${PATH}"
swiftlint
ben-p-commits commented 1 year ago

@sindresorhus , updated per your comment.

image
danispringer commented 1 year ago

I spent quite a while trying to fix this error. Was there some way I should have known about this? Otherwise perhaps we can improve the docs.