search

sindresorhus / Gifski

🌈 Convert videos to high-quality GIFs on your Mac
https://sindresorhus.com/gifski
MIT License
7.72k stars 290 forks source link

Green fringe at bottom of resized GIF #301

Closed marcustyphoon closed 1 year ago

marcustyphoon commented 1 year ago

(Note: Not the same as, but probably related to, #64.)

I'm observing a green fringe that appears whenever I convert a 1920x1080 video to a 540x304 GIF. That I can tell, this happens with any source video; I tried a few 1080p clips from different sources and ran one through Handbrake before selecting it and it always occurred, so I don't think it is a source issue.

I assume a 28.125% scale factor is being applied to the source, yielding a 540x303.75 intermediate, and the chroma channel does something odd that's related to the linked issue. Not sure what the best way to solve this is... always compute the scale factor that fills both output pixel dimensions and use the larger one?

marcustyphoon commented 1 year ago

Oops. Duplicate of #278; I had not realized I was running the non-app-store version.