Closed sindresorhus closed 5 years ago
I'd love to see this one as well.
@issuehunt has funded $100.00 to this issue.
I've been doing some testing and haven't found a way to open the host app from the Share extension. There is an open(:url)
method but I couldn't make it work with this extension.
Was that the idea, or am I missing something?
@AnderGoig we had a similar problem on iOS few years back. From what I remember, you had to climb the responder chain and stop once you got the host app. Not sure if it's gonna work on macOS, but worth a try.
I can do this if it is still relevant.
@Ybrin yes I think it's still relevant so go ahead 👍
Ok I got this but we need to discuss how exactly the process should behave.
Share extensions normally have a custom UI and don't really open the master app to process the shared item. There is a workaround I'm currently using in order to open Gifski and close the share extension immediately but it's more a hack...
How do you want to do this? Should I stick with the hack and just open Gifski with a url and let it handle the rest or should we handle this differently?
If we're going ahead with the "hack" I need to find a way to pass the video file over to Gifski. The url becomes invalid once the share extension is closed as it's not a url to the original location but rather to a tmp folder containing a symlink or something. I guess I will have to copy it over to somewhere and pass this url to Gifski or something. If you have any ideas or know what's happening here let me know please.
@sindresorhus @sunshinejr
@Ybrin UserDefaults with custom suite name? I think this should work between extension & an app. If the hack is working properly, I wouldn't mind it (but leaving the decision to Sindre).
The hack is opening one of the url schemes assigned to Gifski and passing the video uri as a parameter. I don’t like it but I don’t see any other way to open the original app from an extension.
On Mon 7. Oct 2019 at 10:53, Łukasz Mróz notifications@github.com wrote:
@Ybrin https://github.com/Ybrin UserDefaults with custom suite name? I think this should work between extension & an app. If the hack is working properly, I wouldn't mind it (but leaving the decision to Sindre).
— You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/sindresorhus/Gifski/issues/81?email_source=notifications&email_token=ACWUTTLFKJKWB6GNDOB5BR3QNL2HJA5CNFSM4HMH3Z2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAPP74Y#issuecomment-538902515, or mute the thread https://github.com/notifications/unsubscribe-auth/ACWUTTJV3OH34KIXWPDS6P3QNL2HJANCNFSM4HMH3Z2A .
The thing is, I have to open it with a webview in the extension. So the Extension view is actually an empty webview which stays open until Gifski starts launching.
On Mon 7. Oct 2019 at 10:56, Koray Koska koray@koska.at wrote:
The hack is opening one of the url schemes assigned to Gifski and passing the video uri as a parameter. I don’t like it but I don’t see any other way to open the original app from an extension.
On Mon 7. Oct 2019 at 10:53, Łukasz Mróz notifications@github.com wrote:
@Ybrin https://github.com/Ybrin UserDefaults with custom suite name? I think this should work between extension & an app. If the hack is working properly, I wouldn't mind it (but leaving the decision to Sindre).
— You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/sindresorhus/Gifski/issues/81?email_source=notifications&email_token=ACWUTTLFKJKWB6GNDOB5BR3QNL2HJA5CNFSM4HMH3Z2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAPP74Y#issuecomment-538902515, or mute the thread https://github.com/notifications/unsubscribe-auth/ACWUTTJV3OH34KIXWPDS6P3QNL2HJANCNFSM4HMH3Z2A .
@Ybrin Could you use App Groups to copy the video into a shared container that Gifski can access? https://developer.apple.com/documentation/foundation/filemanager/1412643-containerurl
Another possibility it to just pass raw bytes into Gifski from the extension.
@sindresorhus I‘ll have a look into app groups and let you know.
On Mon 7. Oct 2019 at 11:48, Sindre Sorhus notifications@github.com wrote:
@Ybrin https://github.com/Ybrin Could you use App Groups to copy the video into a shared container that Gifski can access?
Another possibility it to just pass raw bytes into Gifski from the extension.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/sindresorhus/Gifski/issues/81?email_source=notifications&email_token=ACWUTTPBEOU2UGIIZOTGV2LQNMAXFA5CNFSM4HMH3Z2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAPVLHQ#issuecomment-538924446, or mute the thread https://github.com/notifications/unsubscribe-auth/ACWUTTIC6VQSC56FVHTZKGTQNMAXFANCNFSM4HMH3Z2A .
@sindresorhus has rewarded $90.00 to @ybrin. See it on IssueHunt
I think it would be useful to create a Share extension for Gifski. That way, any video/screen recording app with a system "Share" button would be able to send a video to Gifski.
This would be especially useful for the built-in macOS screen recording feature. When you're done recording there, you get a thumbnail at the bottom-right of the screen. If you click it, a preview window opens, and in the toolbar, there's a "Share" button. So the user could then quickly send it to Gifski after recording without even having to save the video file.
Thoughts?
IssueHunt Summary
#### [ ybrin](https://issuehunt.io/u/ybrin) has been rewarded. ### Backers (Total: $100.00) - [ issuehunt](https://issuehunt.io/u/issuehunt) ($100.00) ### Submitted pull Requests - [#156 Create Share extension](https://issuehunt.io/r/sindresorhus/gifski-app/pull/156) --- ### Tips - Checkout the [Issuehunt explorer](https://issuehunt.io/r/sindresorhus/gifski-app/) to discover more funded issues. - Need some help from other developers? [Add your repositories](https://issuehunt.io/r/new) on IssueHunt to raise funds. --- IssueHunt has been backed by the following sponsors. [Become a sponsor](https://issuehunt.io/membership/members)