sindresorhus / KeyboardShortcuts

⌨️ Add user-customizable global keyboard shortcuts (hotkeys) to your macOS app in minutes
https://swiftpackageindex.com/sindresorhus/KeyboardShortcuts/documentation/keyboardshortcuts/keyboardshortcuts
MIT License
2.02k stars 186 forks source link

Update Localizable.strings keyboard_shortcuts_can_be_changed for Ventura #97

Open stammy opened 2 years ago

stammy commented 2 years ago

For users on Ventura, instructions for how to change an existing system-wide shortcut are a bit different since System Preferences has been renamed to System Settings and the Shortcuts has been modified a bit as well.

"keyboard_shortcuts_can_be_changed" = "Most system-wide keyboard shortcuts can be changed in “System Preferences › Keyboard › Shortcuts”.";

should become:

"keyboard_shortcuts_can_be_changed" = "Most system-wide keyboard shortcuts can be changed in “System Settings › Keyboard › Keyboard Shortcuts…”.";

sindresorhus commented 2 years ago

English was updated in v1.8.0.

I'll need others to handle the localisations.

sindresorhus commented 2 years ago

// @YazeedAlKhalaf @isametry @Maschina @kant @fejese @2Grey @L1cardo @francisfeng

isametry commented 2 years ago

I've changed the word in Czech and opened a PR. (#99)

sindresorhus commented 2 years ago

Note that you also need update the last part from Shortcuts to Keyboard Shortcuts.

2Grey commented 2 years ago

Does it make sense to add a new localization string for macOS 13.0+?

Because, otherwise the current localized text will become irrelevant for older versions of macOS.

sindresorhus commented 2 years ago

Does it make sense to add a new localization string for macOS 13.0+?

For simplicity, I have decided to just switch to the macOS 13 strings. This text is not super important and the user should be able to figure it out regardless.

2Grey commented 2 years ago

Ok, got you.

Also there isn't need to change Russian localization, because for Russian language name of menu items didn't change.

fejese commented 2 years ago

I'm happy to take a look at this but I don't have Ventura yet to confirm how the Hungarian menu changed

fejese commented 1 year ago

finally got around to check: Hungarian translation is up to date too