sindresorhus / LaunchAtLogin-Legacy

Add “Launch at Login” functionality to your macOS app in seconds
MIT License
1.55k stars 122 forks source link

More robust ONLY_ACTIVE_ARCH comparison #101

Closed davedelong closed 5 months ago

davedelong commented 5 months ago

The help for the ONLY_ACTIVE_ARCH value says:

If enabled, only the active architecture is built. This setting will be ignored when building with a run destination which does not define a specific architecture, such as a 'Generic Device' run destination.

In other words, the compiler only checks for a value of YES; any other value seems to be sufficient to be interpreted as "no: build all architectures".

Therefore, someone who "resets" the value to the default using ONLY_ACTIVE_ARCH = in an xcconfig would result in building all architectures, but still have the helper bundle present in their final build app, which would cause problems with Apple's notarization process.

This change alters the build scripts slightly to remove the helper bundle if it's anything other than YES.

sindresorhus commented 5 months ago

Thanks :)