sindresorhus / Pasteboard-Viewer

📋 Inspect the system pasteboards on macOS
https://sindresorhus.com/pasteboard-viewer
MIT License
708 stars 35 forks source link

Allow clearing pasteboards #28

Closed Aaron-Rumpler closed 1 year ago

Aaron-Rumpler commented 1 year ago

Adds a toolbar button to clear the selected pasteboard (and increases the sidebar minWidth to accomodate).

Fixes #17.

sindresorhus commented 1 year ago

This is not fixing what the issue is describing. It should be a menu item, not a toolbar button. Clearing the clipboard is not such a common need that it needs to be in the toolbar. It could have a keyboard shortcut though, for easy access.

sindresorhus commented 1 year ago

I think we are talking past each other. It should only be in the menu bar, not in the toolbar. There should not be a toggle to show it in the toolbar.

Aaron-Rumpler commented 1 year ago

I was planning on asking whether you'd accept it as an option (either as a visible toggle or as a defaults option not exposed in the UI, as it's something I need for myself), but hadn't gotten to it yet. ~I would also have marked this as a Draft PR if GitHub offered that option to PR authors (both due to not having asked that yet as well as not having the menu option to clear implemented yet).~ (Nevermind. Turns out the option's just hidden in the sidebar.)

sindresorhus commented 1 year ago

I was planning on asking whether you'd accept it as an option (either as a visible toggle or as a defaults option not exposed in the UI, as it's something I need for myself), but hadn't gotten to it yet.

I'm not interested in that. Clearing the pasteboard is not something most people need. Even with a hidden setting, it still adds maintenance overhead.