Closed davedelong closed 5 months ago
Thanks for working on this! This is already looking pretty good.
- I noticed it's quite slow to select something when viewing an image. Not sure if the problem is the framework or the wrapper code.
I took a quick look at this in instruments, and from what I can tell there's an identical spike when showing the text view as showing the hex view. I'm reasonably confident that this is down to retrieving the type.data()
from the pasteboard to provide to the UI. There's probably an optimization that could be made there around caching it once it's been read, so that subsequent calls to .data()
are instantaneous.
Besides the hiccup when showing large datas (like images), all the other feedback has been addressed, including adding the ⌘1 and ⌘2 switcher in the View menu. 😃
(I also confirmed that the branch builds cleanly for iOS)
Looks great 🙌
Update submitted.
This adds a hex viewer to Pasteboard Viewer and fixes #24.
This uses the HexFiend framework to add a hex viewer to the app, which can be accessed by toggling a picker in the toolbar.
Some things to note:
package
branch of the HexFiend project, as that is the branch that adds a Package.swift file. It is technically unreleased, although it appears to be fully functional.