sindresorhus / Plash

💦 Make any website your Mac desktop wallpaper
https://sindresorhus.com/plash
MIT License
3.46k stars 128 forks source link

Make menu bar color adapt to wallpaper #121

Open novyboy opened 1 year ago

novyboy commented 1 year ago

Is your feature request related to a problem? Please describe.

Currently, even when a website with a background is overlaid on top of the desktop with Plash, the menu bar continues to color itself based on the vanilla desktop wallpaper.

Describe the solution you'd like

Add an option that enables you to choose to set menu bar color:

Describe alternatives you've considered

Additional context

The way iWallpaper selects menu bar color is a possible reference for how to do this

sindresorhus commented 1 year ago

See: https://github.com/sindresorhus/Plash#the-menu-bar-does-not-adapt-to-the-plash-wallpaper

sindresorhus commented 1 year ago

iWallpaper works by both setting the actual wallpaper to a static image taken from the video it presents. Plash could potentially do this, but it's not easy as Plash has many more factors to consider. Plash supports transparency and it does not know when the background actually changes (a website could change it dynamically), so Plash would have to constantly poll or risk being outdated.

I guess there could be an opt-in setting for this, but it's not something I plan to work on.