Add toggle shortcut and menu item

sindresorhus / Plash

💦 Make any website your Mac desktop wallpaper

https://sindresorhus.com/plash

MIT License

3.52k stars 130 forks source link

Add toggle shortcut and menu item #131

Closed Lilfaen closed 10 months ago

Lilfaen commented 1 year ago

Hi! I hope contributions are still welcome!

This pr introduces two things:

A toggle shortcut intent that can toggle or set an on/off state for Plash
A menu item to toggle Plash (which would resolve #35

Things I would love some feedback on:

The wording of the menu item. Toggle on/off vs Turn on/off? Any other ideas?
Currently, when toggled off, the standard message for the off-state is shown (see screenshot below). Would a more diverse status system be of interest here with different reasons, at least for the off-state?

Feedback is welcome, love the app ;)

Fixes #35

Lilfaen commented 1 year ago

I just realized the state is reset, e.g. when locking then unlocking the Mac. Maybe the toggle should not directly toggle the isEnabled but rather add another variable that also gets checked in setEnabledStatus()?

Edit: I added a commit with a proof of concept: https://github.com/sindresorhus/Plash/pull/131/commits/bb951acbcedf40fdfd704e1681bd1c9a01545359

sindresorhus commented 1 year ago

I think there should also be a keyboard shortcut setting for toggling Plash.

sindresorhus commented 1 year ago

It incorrectly shows "Deactivated while on battery" when you turn it off.

sindresorhus commented 10 months ago

https://github.com/sindresorhus/Plash/pull/131#issuecomment-1631999549 still needs to be done.

Lilfaen commented 10 months ago

#131 (comment) still needs to be done.

Done https://github.com/sindresorhus/Plash/pull/131/commits/ba3d2556a0f15282ac867a0b1e4b0353a50406ed

sindresorhus commented 10 months ago

Thanks :)