search

sindresorhus / Plash

💦 Make any website your Mac desktop wallpaper
https://sindresorhus.com/plash
MIT License
3.46k stars 128 forks source link

Signing into OAuth apps closes the page #52

Closed jpranaymartin closed 4 years ago

jpranaymartin commented 4 years ago

When trying to sign-in to an app that navigates to an OAuth interstitial, the closing of the login page closes the Plash page instead of navigating to the app being signed into.

Being able to sign into a Notion.so page or similar would be a great use case but seemingly doesn't work. I use the "Sign in with Google" option which is where the problem lies.

Plash 1.5.1 (8) - com.sindresorhus.Plash macOS 10.15.4 MacBookPro16,1

sindresorhus commented 4 years ago

Could you try this build and let me know if it fixes it for you?

Plash-popup-fix.zip

jpranaymartin commented 4 years ago

That fixed it! The sign-in pop-up now opens in a separate window and I'm able to sign in correctly. Looks like the session works across restarts of Plash too, which is fantastic.

Thanks!!

sindresorhus commented 4 years ago

This fix is now out in the App Store.