Closed uruha-komachin closed 3 years ago
Thanks for working on this. I think the code needs to be better abstracted. Having to handle either web view in every single place is not going to be sustainable.
@sindresorhus Hi, I've tried to abstract a little bit more on switching the background webView and the foreground one. Hope that's more clear and maintainable now.
The PR doesn't compile.
I think this PR generally needs more work. Try to refactor it a bit more. Also make sure you try out a lot of different combination of use-cases, to find bugs.
Closing for lack of activity and it's too far from being mergeable.
Using another SSWebView,
webview2
in WebViewController to fix issue #47 and #9.Animation time is set to 0.5 seconds for both fade in and fade out effect. I'm not sure if the animation time brings the best user experience, but please advise and I can make corresponding changes.
Btw, amazing application! 😉