search

sindresorhus / Settings

⚙ Add a settings window to your macOS app in minutes
MIT License
1.45k stars 101 forks source link

NSApp.activate(ignoringOtherApps: true) is deprecated. #102

Closed ShikiSuen closed 1 year ago

ShikiSuen commented 1 year ago

https://github.com/sindresorhus/Settings/blob/1e96f6f4df71da8a0e8cad089015985264fc0d95/Sources/Settings/SettingsWindowController.swift#L100 https://developer.apple.com/documentation/macos-release-notes/appkit-release-notes-for-macos-14 image

DivineDominion commented 1 year ago

Sounds like an easy change with if-#available checks, if needed.

Would you be able to add a PR and test with Xcode 15 beta?

ShikiSuen commented 1 year ago

@DivineDominion A PR is OK and I'm gonna do it. I just don't know how to design a test for this. We can deal with the new unit tests later.

ShikiSuen commented 1 year ago

@DivineDominion Here's the PR now. https://github.com/sindresorhus/Settings/pull/103