search

sindresorhus / Settings

⚙ Add a settings window to your macOS app in minutes
MIT License
1.45k stars 101 forks source link

Update namespace from Settings to AppSettings #118

Closed Kyle-Ye closed 1 year ago

Kyle-Ye commented 1 year ago

Fix conflict when using import SwiftUI and import Settings. Before the commit, downstream users can use import enum Settings.Settings to workaround.

Fix #110 Closes #111

sindresorhus commented 1 year ago

As commented in https://github.com/sindresorhus/Settings/pull/111, it should be a typealias to minimize the changes required.

Kyle-Ye commented 1 year ago

As commented in #111, it should be a typealias to minimize the changes required.

Does it means adding a plain typealias AppSettings = Settings fits you idea?

sindresorhus commented 1 year ago

Does it means adding a plain typealias AppSettings = Settings fits you idea?

Yes

Kyle-Ye commented 1 year ago

Add AppSettings typealias and corresponding doc for it.

SCR-20231101-oxdf
sindresorhus commented 1 year ago

Do you plan any more changes or should I release it?

Kyle-Ye commented 1 year ago

Could you help give a look at #117? Besides that I do not have other changes to make now.