tab transition on High Sierra fails

sindresorhus / Settings

⚙ Add a settings window to your macOS app in minutes

MIT License

1.45k stars 100 forks source link

tab transition on High Sierra fails #38

Closed DivineDominion closed 5 years ago

DivineDominion commented 5 years ago

On High Sierra, I get this when I switch tabs:

*** Assertion failure in -[Preferences.PreferencesTabViewController transitionFromViewController:toViewController:options:completionHandler:], /BuildRoot/Library/Caches/com.apple.xbs/Sources/AppKit/AppKit-1561.60.100/Controllers/NSViewController.m:925

Am investigating!

DivineDominion commented 5 years ago

Ok, so

PreferencesExample produces the error,
my app "Move!" produces the error,
my apps "WordCounter", "TableFlip", and "The Archive" don't

All use the latest commit from master. (adde4ea09fe9c9d85b74d4b10dc4a59ade559783)

DivineDominion commented 5 years ago

Looks like the cross-fading animation is the culprit. For some reason I seem to have figured this out in some of my apps ... :)

if #available(macOS 10.14, *) {
    crossfadeTransitions = true
} else {
    crossfadeTransitions = false
}

Will open a PR with a fix!