search

sindresorhus / Settings

⚙ Add a settings window to your macOS app in minutes
MIT License
1.43k stars 100 forks source link

Bundle identifier without dot characters will cause "Invalid Code Signature Identifier" error #55

Closed nek023 closed 3 years ago

nek023 commented 4 years ago

Hi @sindresorhus, thank you for the nice product!

I'm using this package with Carthage. When I archive and validate my app, I get an "Invalid Code Signature Identifier" error.

invalid-code-signature-identifier

As I investigated, I found that if the framework has no dot characters in its bundle identifier, Xcode appends auto-generated string to signing identifier. And this causes the "Invalid Code Signature Identifier" error.

sindresorhus/KeyboardShortcuts seems to have the same problem, so I'd recommend prepending com.sindresorhus. or something to their bundle identifier.

My environment:

sindresorhus commented 4 years ago

I'm using KeyboardShortcuts in production and not seeing this problem. The Xcode project was generated by Swift Package Manager, so I don't think the info there is incorrect. No one else has reported this either.

sindresorhus commented 3 years ago

Is this still a problem with Xcode 12?

nek023 commented 3 years ago

@sindresorhus Sorry for the late reply. It is still occurring in Xcode 12.3 with Carthage 0.36.0. But there seems to be no other similar reports, I think I should investigate further in my environment. Thank you.