sindresorhus / Settings

⚙ Add a settings window to your macOS app in minutes
MIT License
1.43k stars 100 forks source link

PreferencesWindowController doesn't forward selectors to content #66

Closed nrivard closed 3 years ago

nrivard commented 3 years ago

PreferencesWindowController (as a top-level member of the responder chain) doesnt forward any selectors to content, specifically the selected view controller. And since PWC is also final you can't subclass to do so. So there are 2 solutions:

  1. make PWC open so folks can subclass and handle responder chain actions at that layer
  2. forward the selected view controller for possible handling of responder chain actions

I will make a PR that focus on option #2 as I prefer PWC to be pretty self contained and if all actions are forwarded properly, we can accomplish what we want at the VC level