sindresorhus / Settings

⚙ Add a settings window to your macOS app in minutes
MIT License
1.45k stars 100 forks source link

Rename project to `Settings` #76

Closed sindresorhus closed 1 year ago

sindresorhus commented 2 years ago

Later this year.

ShikiSuen commented 2 years ago

Maybe SDSettings is better. General names like "Settings" and "Preferences" can cause serious confilcts with certain names occupied by Apple.

For example: InputMethodKit preference panel (shown in macOS System Preferences / Settings) requires that the target name of the pref pane has to be "Preferences". This causes building conflict with the "sindresorhus / Preferences" package.

DivineDominion commented 1 year ago

@sindresorhus Looks like there's not much left to do: I spotted that the Sources/ subfolder would need to finally be changed, and applies some renames in #90

Also needs to be changed the window's autosave name:

extension NSWindow.FrameAutosaveName {
    static let settings: NSWindow.FrameAutosaveName = "com.sindresorhus.Preferences.FrameAutosaveName"
}

And the localization strings.

DivineDominion commented 1 year ago

@ShikiSuen The prefixes usually aren't necessary anymore when you can disambiguate by using Swift module names. Wouldn't this also work for the InputMethodKit problem you described?

ShikiSuen commented 1 year ago

@DivineDominion Sorry, it doesn't work. It stops the project from being compiled.

ShikiSuen commented 1 year ago

@DivineDominion Nevertheless, I see that you are about to rebrand this project to Settings. I believe that this will mitigate this issue for the current version of the InputMethodKit. However, InputMethodKit is subject to further unknown changes.

sindresorhus commented 1 year ago

Done: https://github.com/sindresorhus/Settings/releases/tag/v3.0.0