search

sindresorhus / Settings

⚙ Add a settings window to your macOS app in minutes
MIT License
1.43k stars 100 forks source link

Adopt localized resources #82

Closed ghost closed 1 year ago

ghost commented 2 years ago

As of issue https://github.com/sindresorhus/Preferences/issues/77 i localized package strings in a Resource Folder exactly as described in Apple documentation.

PS: while I was trying to sync the fork the initial PR was intentionally merged.

ShikiSuen commented 1 year ago

Please use these modern lang tags for Chinese:

zh-Hans in lieu of zh-CN. zh-Hant in lieu of zh-TW. zh-Hant-HK in lieu of zh-HK.

sindresorhus commented 1 year ago

Closing for lack of activity. Going to leave this for someone else.

DivineDominion commented 1 year ago

@ShikiSuen Could you apply the changes you proposed and open a new PR?

ShikiSuen commented 1 year ago

@DivineDominion I'll see whether I can find some time to do this in this month (Jan).

ShikiSuen commented 1 year ago

@DivineDominion I'll do this after #90 gets merged, reducing possibilities of merging conflicts.