sindresorhus / Settings

⚙ Add a settings window to your macOS app in minutes
MIT License
1.43k stars 100 forks source link

Resizing animations are broken for demo project on Monetery #95

Closed RaimundasSakalauskas closed 1 year ago

RaimundasSakalauskas commented 1 year ago

After failing to understand why this dependency would fail to properly resize window when switching between tabs, I decided to try the example project. It seems that example project has the same issue as my own project.

macOS 12.5.1

Dependency pulled in using SPM.

CleanShot 2023-02-19 at 22 27 02

RaimundasSakalauskas commented 1 year ago

It seems that an issue is with this line of code.

After I have changed isDisjoint(with:) with isSubset(of:).

In the same file there's this code:

        if #available(macOS 10.14, *) {
            options = animated && isAnimated ? [.crossfade] : []
        } else {
            options = []
        }

Since .crossfade animation is used, the statement in question will always result in false.

DivineDominion commented 1 year ago

@RaimundasSakalauskas The change to the linked line of code sounds sensible! Would be great if you create a PR so we can add this.

RaimundasSakalauskas commented 1 year ago

I haven't actually pulled this repo locally. Just changed it in the project that I am using it in.