search

sindresorhus / alfy

Create Alfred workflows with ease
MIT License
2.63k stars 104 forks source link

Make `resolveBodyOnly` overridable #161

Closed gksander closed 1 year ago

gksander commented 2 years ago

What?

This PR allows the resolveBodyOnly fetch option to be overridden from alfy.fetch's options arg.

Why?

Sometimes you need access to response headers. For example, when using GitHub's REST API, the pagination details for paginated endpoints are returned in response headers (instead of response body).

sindresorhus commented 2 years ago

Friendly bump :)

gksander commented 2 years ago

Oh wow, I'm way behind on this. 😅 I've actually been using Raycast as an app launcher lately, which has a nicer authoring flow than Alfred for a guy like me.

Can't promise that I'll get to this soon, but I'll make a metaphorical sticky note to try to get this across the finish line, because I really appreciate what you've done with alfy!

dev99problems commented 2 years ago

Hey @sindresorhus , @gksander looks like I can help with this one if it still makes sense and we want to ship it.

I mean, if it's only the documentation part left, I can cover it! WDYT?

gksander commented 2 years ago

I'll defer to @sindresorhus on:

if it still makes sense and we want to ship it.

Happy for you to either branch from this branch, or for you to create your own branch and just "steal" the code from this PR!

dev99problems commented 2 years ago

@gksander I would checkout from this branch and merge back to it

sindresorhus commented 2 years ago

The best would be to fork the branch of this PR, continue from there, and submit a new pull request.