search

sindresorhus / any-observable

Support any Observable library and polyfill
MIT License
70 stars 12 forks source link

Doesn't seem to work with RxJS 6 #18

Closed SamVerschueren closed 6 years ago

SamVerschueren commented 6 years ago

Is it possible that the auto detect feature doesn't work for RxJS 6? Might have to pull in @benlesh here because I'm not sure what all the changes are in this new version.

So we try to load in rxjs/Observable right here. But it looks like that doesn't exist anymore and you need to import directly from rxjs instead.

So we can easily fix this by adding rxjs to the libs list as the last element in order to support RxJS 6. But before I do a PR, I need to be sure that my findings are correct.

brandonroberts commented 6 years ago

@SamVerschueren Your finding is correct that for RxJS 6, the Observable import should come from rxjs. If the consumer has the rxjs-compat package installed also, either import path will work with version 6.

benlesh commented 6 years ago

This is likely because import locations changed with RxJS 6. It's hard to say, because I don't have time to dig into it.