search

sindresorhus / any-observable

Support any Observable library and polyfill
MIT License
70 stars 12 forks source link

Require Node.js 6 and cleanup #19

Closed SamVerschueren closed 6 years ago

SamVerschueren commented 6 years ago

Fixed all the linting errors with the latest XO. Browser tests are failing though, still have to find what causes this. Also added a .npmrc file.

SamVerschueren commented 6 years ago

Believe I fixed the browser tests. It was just that AVA was not doing any assertions, so added a t.notThrows around execa for the browser tests.

SamVerschueren commented 6 years ago

Darn, will have to revert the const and let stuff as it targets Node 10 :).

sindresorhus commented 6 years ago

Darn, will have to revert the const and let stuff as it targets Node 10 :).

Huh? Do you mean Node.js 4 and not 10? I plan to target Node.js 6 here, so not worry about breaking tests for lower than 6.

SamVerschueren commented 6 years ago

It still tests on 0.10 https://github.com/sindresorhus/any-observable/blob/master/.travis.yml. Maybe because of the browser stuff?

sindresorhus commented 6 years ago

I dunno. Feel free to remove the Node.js <6 stuff.

sindresorhus commented 6 years ago

Thanks for the cleanup :)