search

sindresorhus / any-observable

Support any Observable library and polyfill
MIT License
70 stars 12 forks source link

Support RxJS 6 #23

Closed mcmxcdev closed 5 years ago

mcmxcdev commented 5 years ago

Closes #22.

The PR is in draft state for now, since I didn't have the time yet to test it on an actual project. Can I yarn link to test it?

I had rxjs-compat installed at first to make it a smooth transition and removed it again, so support for RxJS 5 is definitely dropped.

Sorry for all the changes in a single commit, I kind of unexpectedly managed to get it working and passing all the tests right away :)

Looking forward to get some feedback.

IssueHunt Summary ### Referenced issues This pull request has been submitted to: - [#22: Support RxJS 6](https://issuehunt.io/repos/57201062/issues/22) --- IssueHunt has been backed by the following sponsors. [Become a sponsor](https://issuehunt.io/membership/members)
sindresorhus commented 5 years ago

I’m not 100% linking will work. You can just copy-paste the directory into your project’s node_modules directory.

mcmxcdev commented 5 years ago

@sindresorhus yarn link works just fine, fyi ;) I was able to verify that the implementation works with zen-observable as expected through reading the documentation of this repo. The other libs I am unsure how to test them correctly. Can you either try this PR out locally yourself or instruct me how to make sure rxjs-min etc. still work?

sindresorhus commented 5 years ago

Can you either try this PR out locally yourself or instruct me how to make sure rxjs-min etc. still work?

I honestly don't know. I don't use RxJS.

sindresorhus commented 5 years ago

The changes look good to me :)