search

sindresorhus / any-observable

Support any Observable library and polyfill
MIT License
70 stars 12 forks source link

Just use rxjs-minimal instead of both rxjs-full and minimal #3

Closed jamestalmage closed 8 years ago

jamestalmage commented 8 years ago

See this comment.

RxJs uses an interesting loader mechanism that allows users to specify exactly which Observable methods are implemented. This allows them to pursue a robust API, and users don't necessarily have to pay the price with larger browserified packages. (I think you can accomplish similar with bluebird, but it requires a build step - rxjs automates feature selection via require/import statements - it's pretty cool). More details here

Anyways. I think we should probably just select the minimal install when auto-resolving. Then users can patch to get the features they want, but we aren't necessarily loading the entirety of rxjs.

sindresorhus commented 8 years ago

Agreed.

Just need to make sure to document how to get the full one:

Might be worth explaining that in the docs here, even though it's an rxjs implementation detail. Especially if we default to the minimal one over the full one. - https://github.com/sindresorhus/any-observable/commit/33293a53fb7b242aa61c42ea036db5bd849ababf#commitcomment-17275070