Closed yudai-nkt closed 7 years ago
Hey @yudai-nkt, thank you -- this is pretty good, i would love to add this to the next release.
Even though the new matchers are pretty more explicit they currently do not match uppercase values. I would appreciate if you could add case insensitiveness but i guess we need to use char-classes ([oO][fF][fF]
) implement that.
I can do it, too but it will take its time.
P.s.: The .editorconfig of this repo is not complete. I need to add that rule.
I would appreciate if you could add case insensitiveness
Sure, I've added that feature. I didn't notice that EditorConfig is case insensitive although it's documented in Wiki.
Awesome! I wasn't aware of that, too.. 😄
To make the maintainer's life easier, I...
npm test
ed my code and it's green like an :green_apple:,readme.md
, if it was necessary andreadme.md
, I guess.The current grammar is quite rough and it matches to anything in the form of
key = value
. This PR disallows matching to such malformed settings and only highlights valid ones listed in EditorConfig's Wiki. This will visually help users notice invalid lines (e.g., they made a typo or didn't remember the correct key/value name).P.S. The default
indent_style
is set totab
in.editorconfig
of this repo, butgrammars/ini.cson
uses 2-space indentation. I respected the consistency in a file.