sindresorhus / atom-editorconfig

Helps developers maintain consistent coding styles between different editors
https://atom.io/packages/editorconfig
MIT License
812 stars 80 forks source link

Optimise grammar and correct property scopes #117

Closed Alhadis closed 7 years ago

Alhadis commented 7 years ago

To make the maintainer's life easier, I...

Resolves #115.

This could actually be optimised even further in size, but I'm assuming the pattern placement is deliberate (e.g., highlighting keywords only in the context of their relevant properties). I've therefore left it as-is.

florianb commented 7 years ago

@Alhadis thank you very much! I didn't know the mode-modifiers do work for js-regex (and or naively assumed Atom relies on the js-engine). I test and approve it as soon as possible! 👍

Alhadis commented 7 years ago

Atom doesn't use JavaScript's crappy regex for syntax highlighting, heh. It uses the Oniguruma engine, which is also used by Ruby and TextMate. =)

And no problem, my pleasure. 👍

florianb commented 7 years ago

Hah! These are great news! 👏