sindresorhus / atom-editorconfig

Helps developers maintain consistent coding styles between different editors
https://atom.io/packages/editorconfig
MIT License
812 stars 80 forks source link

Can not hide wrap-guide #128

Closed KarolAltamirano closed 7 years ago

KarolAltamirano commented 7 years ago

After updating to v2.0.0 I am not able to hide wrap guide. Wrap guide is displayed even when wrap-guide package is disabled. When I disable also atom-editorconfig package the wrap guide disappears but I am not able to hide wrap guide when atom-editorconfig package is enabled.

florianb commented 7 years ago

@KarolAltamirano thanks for reporting that issue. Please provide your editorconfig-file and which file-endings are affected.

KarolAltamirano commented 7 years ago

Hi @florianb, thank you for your quick reply.

My .editorconfig file looks like this:

root = true
[*]
indent_style = space
indent_size = 2
end_of_line = lf
charset = utf-8
trim_trailing_whitespace = true
insert_final_newline = true

[*.md]
trim_trailing_whitespace = false

I think the issue may be something with the new rule in version 2.0.0 max_line_length.

Attaching image: [

screen shot 2016-11-01 at 7 24 11 pm

](url)

As you can see on the picture above there is a line (wrap guide) visible on the right but I have disabled wrap-guide package. So there is no way to hide this wrap guide. When I disable atom-editorconfig package the line is gone as expected. So probably it is something with this package. I am on mac os. Let me know if you can't reproduce and I can provide you more information.

florianb commented 7 years ago

@KarolAltamirano you are welcome -- thank you very much for your fast response! I am trying to reproduce your issue and we have likely a bug here.

Could you please add a screenshot of the output of the EditorConfig: Show State-command? I am especially interested in the value for max_line_length. Thanks in advance! 💝

KarolAltamirano commented 7 years ago

Adding the screenshot

screen shot 2016-11-01 at 7 42 40 pm
florianb commented 7 years ago

@KarolAltamirano thanks a lot - i am investigating this issue.

KarolAltamirano commented 7 years ago

@florianb thank you very much. I need to go offline now but if there is anything else that would help you investigating the issue let me know, I will answer you once I'm back.

florianb commented 7 years ago

@KarolAltamirano no worries - the patch 2.0.1 is pending and should resolve this issue. I would appreciate if you could check if this solves the issue for you. I am sorry for any inconveniences - thank you for your support! 🎁

KarolAltamirano commented 7 years ago

@florianb works great!!! Thank you for fixing it so quickly.