sindresorhus / atom-editorconfig

Helps developers maintain consistent coding styles between different editors
https://atom.io/packages/editorconfig
MIT License
812 stars 80 forks source link

soft wrap gets re-enabled automatically. #142

Closed kentcdodds closed 7 years ago

kentcdodds commented 7 years ago

Involved .editorconfig-files

N/A

Directory structure

N/A

Installed packages

Built-in Atom Packages (89)
├── atom-dark-syntax@0.27.0
├── atom-dark-ui@0.52.0
├── atom-light-syntax@0.28.0
├── atom-light-ui@0.44.0
├── base16-tomorrow-dark-theme@1.2.0
├── base16-tomorrow-light-theme@1.2.0
├── one-dark-ui@1.6.0
├── one-light-ui@1.6.0
├── one-dark-syntax@1.3.0
├── one-light-syntax@1.3.0
├── solarized-dark-syntax@1.0.2
├── solarized-light-syntax@1.0.2
├── about@1.7.0
├── archive-view@0.61.1
├── autocomplete-atom-api@0.10.0
├── autocomplete-css@0.11.2
├── autocomplete-html@0.7.2
├── autocomplete-plus@2.31.1
├── autocomplete-snippets@1.11.0
├── autoflow@0.27.0
├── autosave@0.23.1
├── background-tips@0.26.1
├── bookmarks@0.42.0
├── bracket-matcher@0.82.1
├── command-palette@0.38.0
├── deprecation-cop@0.54.1
├── dev-live-reload@0.47.0
├── encoding-selector@0.22.0
├── exception-reporting@0.40.0
├── find-and-replace@0.201.1
├── fuzzy-finder@1.4.0
├── git-diff@1.1.0
├── go-to-line@0.31.0
├── grammar-selector@0.48.2
├── image-view@0.59.0
├── incompatible-packages@0.26.1
├── keybinding-resolver@0.35.0
├── line-ending-selector@0.5.0
├── link@0.31.1
├── markdown-preview@0.158.0
├── metrics@1.0.0
├── notifications@0.65.1
├── open-on-github@1.2.0
├── package-generator@1.0.0
├── settings-view@0.242.2-hotfix1
├── snippets@1.0.2
├── spell-check@0.68.2
├── status-bar@1.4.1
├── styleguide@0.47.0
├── symbols-view@0.113.1
├── tabs@0.101.0
├── timecop@0.33.2
├── tree-view@0.209.3
├── update-package-dependencies@0.10.0
├── welcome@0.35.1
├── whitespace@0.33.0
├── wrap-guide@0.38.2
├── language-c@0.52.1
├── language-clojure@0.21.0
├── language-coffee-script@0.47.2
├── language-csharp@0.12.1
├── language-css@0.37.1
├── language-gfm@0.88.0
├── language-git@0.15.0
├── language-go@0.42.1
├── language-html@0.45.1
├── language-hyperlink@0.16.0
├── language-java@0.23.0
├── language-javascript@0.119.0
├── language-json@0.18.2
├── language-less@0.29.5
├── language-make@0.22.2
├── language-mustache@0.13.0
├── language-objective-c@0.15.1
├── language-perl@0.35.0
├── language-php@0.37.2
├── language-property-list@0.8.0
├── language-python@0.45.0
├── language-ruby@0.69.0
├── language-ruby-on-rails@0.25.0
├── language-sass@0.56.0
├── language-shellscript@0.22.4
├── language-source@0.9.0
├── language-sql@0.23.0
├── language-text@0.7.1
├── language-todo@0.28.0
├── language-toml@0.18.0
├── language-xml@0.34.9
└── language-yaml@0.26.0

Community Packages (23) /Users/kdodds/.atom/packages
├── atom-ternjs@0.15.0
├── autocomplete-emojis@2.5.0
├── autocomplete-json@5.1.0
├── autocomplete-modules@1.6.7
├── custom-invisibles@0.1.2
├── docblockr@0.8.7
├── editorconfig@2.0.4
├── expand-region@0.2.5
├── file-icons@1.7.24
├── highlight-selected@0.11.2
├── hyperclick@0.0.39
├── js-hyperclick@1.9.0
├── language-babel@2.47.0
├── language-json5@1.1.0
├── linter@1.11.18
├── linter-eslint@8.0.0
├── linter-flow@5.5.0
├── linter-jsonlint@1.3.0
├── local-history@3.4.1
├── open-this@0.3.0
├── relative-numbers@0.5.1
├── terminal-plus@0.14.5
└── vim-mode-plus@0.65.0

└── (empty)

Here's a gif of the behavior:

wrap-editorconfig

You'll notice that once I install the plugin, the file gets softwrapped every time I change tabs to it. I forgot to uncheck the "Soft Wrap" option in the gif, but doing that doesn't make a difference, the behavior is the same.

This is really annoying. I think this must have happened fairly recently. I don't know the codebase, but this might be related?

Thanks!

florianb commented 7 years ago

@kentcdodds thanks for reporting this! The editoroconfig should not change the wrap-configuration if there is no max_line_length applied. Could you please add the output of the EditorConfig: Show State-command?

kentcdodds commented 7 years ago

Sure:

screen shot 2016-11-07 at 11 59 54 pm
kentcdodds commented 7 years ago

It appears that there is a max-line-length applied, but I wouldn't expect that to soft wrap if Soft Wrap is not checked.

florianb commented 7 years ago

@kentcdodds -- this is the normal behavior. Since a raising number of users complain about this implementation i am probably going to change the behavior.

Even though i don't understand why people set a max_line_length if they don't want it being applied.

You're welcome to join the discussion for enhancement in #143. ☕️