sindresorhus / atom-editorconfig

Helps developers maintain consistent coding styles between different editors
https://atom.io/packages/editorconfig
MIT License
811 stars 80 forks source link

Deprecated selector in `editorconfig/styles/atom-editorconfig.less` #144

Closed rumpelsepp closed 7 years ago

rumpelsepp commented 7 years ago

In editorconfig/styles/atom-editorconfig.less:

Starting from Atom v1.13.0, the contents of atom-text-editor elements are no longer encapsulated within a shadow DOM boundary. This means you should stop using :host and ::shadow pseudo-selectors, and prepend all your syntax selectors with syntax--. To prevent breakage with existing style sheets, Atom will automatically upgrade the following selectors:

Automatic translation of selectors will be removed in a few release cycles to minimize startup time. Please, make sure to upgrade the above selectors as soon as possible.

florianb commented 7 years ago

Thanks @rumpelsepp -- i expected this to happen but couldn't find the resource. I will add this the next time i'm touching the source. πŸ˜„ πŸ’

rumpelsepp commented 7 years ago

I just used the atom build in report issue button. It generated this text automatically :D

florianb commented 7 years ago

πŸ˜† Manchmal sieht man vor lauter BΓ€umen den Wald nicht.. πŸŽ„

rumpelsepp commented 7 years ago

so schauts aus. :)

florianb commented 7 years ago

Fixed with #146