search

sindresorhus / atom-editorconfig

Helps developers maintain consistent coding styles between different editors
https://atom.io/packages/editorconfig
MIT License
812 stars 80 forks source link

Setting max_line_length causes atom wrap-guide to disappear #163

Closed mik01aj closed 7 years ago

mik01aj commented 7 years ago

I noticed that enabling max_line_length in my (global) .editorconfig causes the wrap-guide to disappear. And removing this line causes the guide to appear again. Looks like a bug to me.

.editorconfig file:

[*]
max_line_length = 80

Disabling and re-enabling the wrap-guide package helps, but only for the currently open editor pane.

Related comment by @florianb from #143:

It might be that the wrap-guide implementation is faulty due to the current transition of Atom towards 1.13.

florianb commented 7 years ago

@mik01aj -- thanks a lot! I assume you're using Atom 1.12.x?

rjmunro commented 7 years ago

I find that setting max_line_length always causes soft-wrap to that width, even though I do not have "soft wrap at preferred line length" enabled.

florianb commented 7 years ago

@rjmunro - that's the current implementation according to the standard. See #142 and #133.

cliffordfajardo commented 7 years ago

Just wanted to show a visual of what's happening. Immediately after adding max_line_length and saving, the wrap guide line to go away. (Atom 1.12.7)

editorconfig

florianb commented 7 years ago

@cliffordfajardo, @rjmunro, @mik01aj: i refactored the wrap-guide implementation. I hope this issue is now fixed. I would appreciate if anybody could prove this. Thanks or your patience! ☕️

cliffordfajardo commented 7 years ago

@florianb - I'm not experiencing the problem anymore 🎉😀. Thanks!