Editorconfig should be applied on "Window Reload"-event

sindresorhus / atom-editorconfig

Helps developers maintain consistent coding styles between different editors

https://atom.io/packages/editorconfig

MIT License

811 stars 80 forks source link

Editorconfig should be applied on "Window Reload"-event #176

Closed florianb closed 1 year ago

florianb commented 7 years ago

While developing the editoroconfig is not reapplied if reloading the window with the "Window: Reload"-command.

Unfortunately i have no idea, how to get notified of a finished reload.

IssueHunt Summary

### Sponsors (Total: $30.00) - [

issuehunt](https://issuehunt.io/u/issuehunt) ($30.00) #### [Become a sponsor now!](https://issuehunt.io/r/sindresorhus/atom-editorconfig/issues/176) #### [Or submit a pull request to get the deposits!](https://issuehunt.io/r/sindresorhus/atom-editorconfig/issues/176) ### Tips - Checkout the [Issuehunt explorer](https://issuehunt.io/r/sindresorhus/atom-editorconfig/) to discover more funded issues. - Need some help from other developers? [Add your repositories](https://issuehunt.io/r/new) on IssueHunt to raise funds.

dmytrokyrychuk commented 7 years ago

@florianb You don't need to be notified of a finished reload in order to make editorconfig to be reapplied on a reload. From the package's point of view a reload is no different from a restart: your package's deactivate will be called before reload, and activate will be called after reload completed. If the package correctly cleans up its resources during deactivate, further call to activate should work as it if Atom just started.

The only thing I was concerned about is that all the editorconfig-related things are being attached to buffers directly. But it appears that buffers and editors are getting destroyed upon a reload, so you don't need to do anything in order to make editorconfig to be reapplied on Window Reload, it gets reapplied already.

florianb commented 5 years ago

I decided to drop maintenance. Sorry.

See https://github.com/sindresorhus/atom-editorconfig/issues/231

IssueHuntBot commented 5 years ago

@issuehunt has funded $30.00 to this issue.

Submit pull request via IssueHunt to receive this reward.
Want to contribute? Chip in to this issue via IssueHunt.
Checkout the IssueHunt Issue Explorer to see more funded issues.
Need help from developers? Add your repository on IssueHunt to raise funds.

sindresorhus commented 1 year ago

Closing as Atom is abandoned.