max_line_length-guide is broken

[florianb]

..since the usage of the wrap-guide element has changed, and the wrap-guide instance isn't part of the DOM-element anymore.

IssueHunt Summary

### Sponsors (Total: $40.00) - [ issuehunt](https://issuehunt.io/u/issuehunt) ($40.00) #### [Become a sponsor now!](https://issuehunt.io/r/sindresorhus/atom-editorconfig/issues/190) #### [Or submit a pull request to get the deposits!](https://issuehunt.io/r/sindresorhus/atom-editorconfig/issues/190) ### Tips - Checkout the [Issuehunt explorer](https://issuehunt.io/r/sindresorhus/atom-editorconfig/) to discover more funded issues. - Need some help from other developers? [Add your repositories](https://issuehunt.io/r/new) on IssueHunt to raise funds.

[florianb]

Okaydo - i fiddled around a lot and we're not able to intercept the wrap-guide anymore. I will implement a custom max-line-length element to the package. This will land hopefully this week.

As always help is welcome and i'd be thankful if anybody would try to create it.

[ameenross]

Any news on this? I was just trying out the max_line_length and didn't notice any difference. Then I found this issue.

[manuelbieh]

If, by "broken", you mean Atom does not respect the max_line_length setting to adjust the long line guide accordingly I still have that problem. Not sure if it ever worked but I left the Preferred Line Length setting in Atom untouched (defaults to 80) and usually set max_line_length in my .editorconfig to 100 but the guide is still at 80.

Is it because I don't have soft wrap enabled or does anybody have an idea how I can move the guide to that 100 mark?

[ameenross]

the guide is still at 80

Here's the answer:

we're not able to intercept the wrap-guide anymore

My question was i.r.t. this statement:

I will implement a custom max-line-length element to the package. This will land hopefully this week.

[florianb]

Hi @ameenross, @manuelbieh - thanks for getting in touch. I started rewriting the package in order to fix this issue. Unfortunately i'm currently not making much progress since the lack of time. I'd like to give you news on this but it seems like you'll still have some patience until the package picks up to the current release of Atom again.

[florianb]

I decided to drop maintenance. Sorry.

See https://github.com/sindresorhus/atom-editorconfig/issues/231

[Alhadis]

This should have been fixed by 021d0ea. See related issues #232 and #226.

Gonna close this as resolved; if any of you experience this again, don't hesitate to open a new issue. 👍

[ameenross]

Thanks for taking over this project! What version of Atom do we need for this to work? I'm not seeing it yet.

[Alhadis]

@ameenross I tested this with the latest Atom Nightly (1.37.0-nightly0) as well as stable (1.34.0). Could you provide a list of which packages you have installed/activated? It's possible there's something screwing with the package (as usual…)

[ameenross]

@Alhadis

Built-in Atom Packages (93)
├── atom-dark-syntax@0.29.1
├── atom-dark-ui@0.53.3
├── atom-light-syntax@0.29.1
├── atom-light-ui@0.46.3
├── base16-tomorrow-dark-theme@1.6.0
├── base16-tomorrow-light-theme@1.6.0
├── one-dark-ui@1.12.5
├── one-light-ui@1.12.5
├── one-dark-syntax@1.8.4
├── one-light-syntax@1.8.4
├── solarized-dark-syntax@1.3.0
├── solarized-light-syntax@1.3.0
├── about@1.9.1
├── archive-view@0.65.1
├── autocomplete-atom-api@0.10.7
├── autocomplete-css@0.17.5
├── autocomplete-html@0.8.8
├── autocomplete-plus@2.42.0
├── autocomplete-snippets@1.12.0
├── autoflow@0.29.4
├── autosave@0.24.6
├── background-tips@0.28.0
├── bookmarks@0.45.1
├── bracket-matcher@0.90.4
├── command-palette@0.43.5
├── dalek@0.2.2
├── deprecation-cop@0.56.9
├── dev-live-reload@0.48.1
├── encoding-selector@0.23.9
├── exception-reporting@0.43.1
├── find-and-replace@0.215.14
├── fuzzy-finder@1.8.2
├── github@0.23.3
├── git-diff@1.3.9
├── go-to-line@0.33.0
├── grammar-selector@0.50.1
├── image-view@0.63.1
├── incompatible-packages@0.27.3
├── keybinding-resolver@0.38.4
├── line-ending-selector@0.7.7
├── link@0.31.6
├── markdown-preview@0.159.25
├── metrics@1.6.2
├── notifications@0.70.5
├── open-on-github@1.3.1
├── package-generator@1.3.0
├── settings-view@0.257.2
├── snippets@1.4.0
├── spell-check@0.74.2
├── status-bar@1.8.15
├── styleguide@0.49.12
├── symbols-view@0.118.2
├── tabs@0.109.2
├── timecop@0.36.2
├── tree-view@0.224.5
├── update-package-dependencies@0.13.1
├── welcome@0.36.7
├── whitespace@0.37.7 (disabled)
├── wrap-guide@0.40.3
├── language-c@0.60.14
├── language-clojure@0.22.7
├── language-coffee-script@0.49.3
├── language-csharp@1.1.0
├── language-css@0.43.0
├── language-gfm@0.90.6
├── language-git@0.19.1
├── language-go@0.46.6
├── language-html@0.51.5
├── language-hyperlink@0.17.0
├── language-java@0.31.1
├── language-javascript@0.129.19
├── language-json@0.19.2
├── language-less@0.34.3
├── language-make@0.23.0
├── language-mustache@0.14.5
├── language-objective-c@0.15.1
├── language-perl@0.38.1
├── language-php@0.44.1
├── language-property-list@0.9.1
├── language-python@0.51.8
├── language-ruby@0.72.14
├── language-ruby-on-rails@0.25.3
├── language-rust-bundled@0.1.0
├── language-sass@0.62.0
├── language-shellscript@0.27.9
├── language-source@0.9.0
├── language-sql@0.25.10
├── language-text@0.7.4
├── language-todo@0.29.4
├── language-toml@0.18.2
├── language-typescript@0.4.11
├── language-xml@0.35.3
└── language-yaml@0.32.0

Community Packages (16)
├── atom-beautify@0.33.4
├── atom-debug-ui@1.0.4
├── atom-ide-ui@0.13.0
├── atom-minify@0.8.0
├── busy-signal@2.0.0
├── editorconfig@2.3.0
├── git-blame@1.8.0
├── intentions@1.1.5
├── language-blade@0.41.4
├── language-json5@1.1.1
├── merge-conflicts@1.4.5
├── php-debug@0.3.5
├── php-ide-serenata@4.5.1
├── php-twig@4.0.0
├── platformio-ide-terminal@2.9.0
└── project-manager@3.3.6

[Alhadis]

Ah sorry, forgot to mention: Could you include the version of Atom you have installed?

Wouldn't hurt to grab what system you're running too (and the version/distro, if possible).

At a glance, can't see any packages there that look like they'd be troublemakers. 😕

[ameenross]

Ubuntu 18.04, Atom 1.34.0

Also, disabling all community packages except editorconfig did not make the wrap guide work, it stays at 80 chars

[Alhadis]

Alright, few questions about the workspace:

1. Is the root folder of the project a Git repository?
2. What file are you testing this with when you say the wrap-guide isn't working?
3. What are the rules stored in your .editorconfig file(s)?

[ameenross]

The project is a git repo, editing a PHP file with these rules:

# top-most EditorConfig file
root = true

# Unix-style newlines with a newline ending every file and 4-space indentation.
[*]
end_of_line = lf
insert_final_newline = true
indent_style = space
indent_size = 4
trim_trailing_whitespace = true
insert_final_newline = true

[*.php]
max_line_length = 120

[Alhadis]

Alright, what about the file's physical path? Does it reside within one of the project folders, or is it located outside the root directory?

Also, are you seeing this in an editor you had open when the editor was launched? There's currently some bugginess with editors which are open at startup... try closing the file and reopening it. Does that help?

[ameenross]

FWIW, the other properties do work, like indent_size. Just changed it to 6 to test. It's in the root of the project.

I'm working right now, so opening and closing PHP files regularly. Don't see it.

[Alhadis]

Reopening this, as there's (obviously) still an issue here.

Does a max_line_length of less than 80 (e.g., ~30-40) make a difference? Trying to gauge if this issue is connected to atom/wrap-guide#56, which I had to kludge a fix for to stop breakage in nightly releases (#232).

The fix I applied isn't perfect because it doesn't consider multiple guides when updating the position of the wrap-guide. Should open a new issue about that, actually...

[ameenross]

No difference.

Also tried moving ~/.atom for a fresh profile, installing editorconfig and nothing else, still no go.

[IssueHuntBot]

@issuehunt has funded $40.00 to this issue.

---

• Submit pull request via IssueHunt to receive this reward.
• Want to contribute? Chip in to this issue via IssueHunt.
• Checkout the IssueHunt Issue Explorer to see more funded issues.
• Need help from developers? Add your repository on IssueHunt to raise funds.

[ameenross]

I must admit that I recently saw the length guide starting to work. Maybe a month ago or so.

Might have been version 2.4.0, I'm not sure.

[sindresorhus]

Closing as Atom is abandoned.