sindresorhus / atom-editorconfig

Helps developers maintain consistent coding styles between different editors
https://atom.io/packages/editorconfig
MIT License
812 stars 80 forks source link

Replace 'auto' with 'unset' per the new spec #194

Closed alaycock closed 7 years ago

alaycock commented 7 years ago

To make the maintainer's life easier, I...

Resolves https://github.com/sindresorhus/atom-editorconfig/issues/193

I updated the grammar and changed all relevant instances of auto to unset per the new terminology. If you search the repo, there are a few instances of auto left, but those referring to Atom's built in 'tab type' setting. It made more sense to update every instance of auto to unset to prevent conflicting terminology throughout the repo, although it isn't necessary to do so.

I also added a new test, to show that when any of the properties are unset, the settings in the plugin will match that.

florianb commented 7 years ago

Well done @alaycock!

Your changes look good to me, i will have a deeper look at Tuesday and i guess i will then accept the PR, too. Thank you very much for your contribution!

🎁

florianb commented 7 years ago

I owe you a beer @alaycock - thank you very much for your support! 🍻

alaycock commented 7 years ago

Glad I could help 🍻