search

sindresorhus / atom-editorconfig

Helps developers maintain consistent coding styles between different editors
https://atom.io/packages/editorconfig
MIT License
812 stars 80 forks source link

Add support for the new buffer API #203

Closed samcv closed 5 years ago

samcv commented 6 years ago

Issuehunt badges

The whitespace package added support here: https://github.com/atom/whitespace/pull/157/

The new API was added to Atom here: https://github.com/atom/atom/pull/14435

This should greatly speed up removing trailing whitespace for files, especially for large files.

IssueHunt Summary ### Sponsors (Total: $60.00) - [issuehunt issuehunt](https://issuehunt.io/u/issuehunt) ($60.00) #### [Become a sponsor now!](https://issuehunt.io/r/sindresorhus/atom-editorconfig/issues/203) #### [Or submit a pull request to get the deposits!](https://issuehunt.io/r/sindresorhus/atom-editorconfig/issues/203) ### Tips - Checkout the [Issuehunt explorer](https://issuehunt.io/r/sindresorhus/atom-editorconfig/) to discover more funded issues. - Need some help from other developers? [Add your repositories](https://issuehunt.io/r/new) on IssueHunt to raise funds.
florianb commented 6 years ago

Hi @samcv - thank you very much for getting in touch and this delightful hint. I would like to add this enhancement to the next release.

I'd like to beg for patience until i'm back from vacation (next week). 😄 ☕️

samcv commented 6 years ago

@florianb no problem. Glad the information was apreciated and thank you for your work on the EditorConfig package. :-)

IssueHuntBot commented 5 years ago

@issuehunt has funded $60.00 to this issue.

Alhadis commented 5 years ago

Nothing to do here, really. We're already using the TextBuffer API's methods for efficient searching/replacing; the optimisations referred to in atom/whitespace#157 were addressing the use of String.prototype.search instead of the search logic provided natively TextBuffer.